Add "model" macro to simplify model definitions #625
Merged
+405
−116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjkirch
force-pushed
the
model-macro
branch
2 times, most recently
from
579b187
to
79f750d
Compare
|
(The pushes clean up two typos) |
bcressey
approved these changes
Jan 4, 2020
This removes a lot of repetitive attributes and type modifiers through the use of an attribute-style procedural macro applied to our model structs.
|
This push fixes a typo caught by bcressey. |
iliana
approved these changes
Jan 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a lot of repetitive attributes and type modifiers through the use
of a attribute-style procedural macro applied to our model structs.
See the README for the exact changes the macro makes. See the models for how simple they are now :)
Testing done:
I used cargo-expand to compare the generated
modelpackage before and after. The only changes were whitespace, ordering of attributes, the newuseof model-derive, and the intentional removal of therustfmt::skipthat's no longer needed.I built and launched an aws-k8s AMI, confirmed all services
running, and the API showed all settings. A pod ran OK.I built and launched an aws-dev AMI, it was
running, showed all settings, and a Docker container ran OK.